soundcloud / lightcycle

LightCycle lets self-contained classes respond to Android’s lifecycle events
http://soundcloud.github.io/lightcycle/
Apache License 2.0
705 stars 55 forks source link

Rewrite lightcycle-processor test #67

Closed NikoYuwono closed 8 years ago

NikoYuwono commented 8 years ago

This is a proposal to use different approach to write test classes.
In https://github.com/soundcloud/lightcycle/pull/64 we talked about lightcycle-processor test can't be run directly from IDE, and after I checked lightcycle-processor test source code, looks like for now Android Studio can't find the file from resources directory.

In this pull request I rewrote the approach from getting the file from resource directory to write the java source file as a String directly in the test classes.

After thinking and rewriting about this approach this is my conclusion

Pros :

Cons :

Note :

glung commented 8 years ago

great ! I try to release asap and I'll give you a heads up.

What is you twitter handle ?

NikoYuwono commented 8 years ago

@niko_yuwono ! Thank you very much! Will do the checkstyle this weekend :)