LightCycles don’t need to know about android.

soundcloud / lightcycle

LightCycle lets self-contained classes respond to Android’s lifecycle events

http://soundcloud.github.io/lightcycle/

Apache License 2.0

705 stars 55 forks source link

LightCycles don’t need to know about android. #87

Closed glung closed 7 years ago

glung commented 7 years ago

For applications, it allows presenters (LightCycles) to use views - which can be implemented by Fragment or Activity classes.

Dispatcher: dispatch the Android life cycle (Activity, SupportFragment, Fragment) to LightCycles.
Host: the activity/fragment as viewed by the light cycle. It can be a view.
LightCycle: notified of the life cycle with the Host as a parameter.

https://github.com/soundcloud/lightcycle/issues/48

NikoYuwono commented 7 years ago

Just for confirmation, the view here is view in MV* Architecture right? not Android View? While in this topic, do you think supporting Android View would be a good option?

glung commented 7 years ago

@NikoYuwono

The View is indeed the V of the MVP. Do you think the naming is confusing ? I am open to suggestions
I never thought about adding light cycle to Views, neither to Application because we just don't need it at SoundCloud. I gave it some thoughts and I can't tell it would be easy: it would mean subclassing a view to use a ViewDisaptcher, unless the view tree can be used.

Long story short, it is not part of the V2 roadmap as of now.

NikoYuwono commented 7 years ago

@glung

Sorry but I don't think I can come with better name, let's keep with this rule to use View to mention V of the MV* architecture and Android View for Android's View.
Yes that's why I ask, would we got a merit from it or not, for now I don't think it can be really useful use case for the user, so let's let it go for now.

Thanks for the reply!

luispereira commented 7 years ago

Can you release this, since there are more people looking for this feature?

glung commented 7 years ago

Check 1.6.0. I will communicate the release after more testing but you can already use it