search

soundscape-community / soundscape

An iOS application/service that aids navigation through spatialized audio
https://soundscape.services
MIT License
21 stars 22 forks source link

Start the setup process start in the language that the iPhone is set to #112

Open jchudge opened 1 month ago

jchudge commented 1 month ago

Based on user feedback

The current version of Soundscape starts the setup process in English when the app is first installed. Then the user could change the language in the middle of the setup. I'd like to have the setup process start in the language that the iPhone is set to, but I feel that the language question to choose another language should not be eliminated in case the user is bilingual. The app should default to English only if the phone is already set to English or if the iPhone is set to a language not supported by Soundscape.

Also, the Soundscape Language screen is missing from the U.S. English version of the App Setup in the help documentation but it's there in the U.K. English version.

ryanThomas21 commented 1 month ago

I'll look into this

ryanThomas21 commented 1 month ago

It seems like depending on the types of languages the user chooses the language won't update. This may be because of the region the languages are from and whether or not those specific types of a certain language are in our list of languages. For example if I put Spanish U.S. as my default language in the simulator, this won't be picked up and will start the app in english. However, if I use Spanish (Spain) it will change the startup language.

steinbro commented 4 weeks ago

Here's the logic that sometimes skips the language selection during app setup: https://github.com/soundscape-community/soundscape/blob/b48232d630a3fb923f4ebf57fe3cdf3b1ab6dfc1/apps/ios/GuideDogs/Code/Visual%20UI/Views/Onboarding/OnboardingWelcomeView.swift#L22-L26

So the user is presented with language selection only if the device locale and app locale don't match. I'm not sure what that means in practice.