Closed weblate closed 1 week ago
Before commiting this pull request, I suggest we change the name of the "Enter Vicinity Distance" button because that phrase is hard to translate to Spanish. The word "enter" is tricky. I tried translating using the term more commonly used for going inside physical places, but another translator suggested using the term more commonly used for data entry. I think it's ok to just drop the word "enter," and the function still makes sense.
I agree that the "enter" is unnecessary. The reason it's there is because there's actually a second parameter in the code, Leave Vicinity Distance, but it's not configurable (it's calculated relative to the Enter Vicinity Distance). I think "Audio Mute Distance" is a good replacement.
Thanks. I'll change it to "Audio Mute Distance." In the future, if we ever add the "Auto Unmute" feature I proposed in another issue, it might be a better idea to call it "Delayed Start" to avoid too much repetition. Also that phrase is a bit of an Easter egg because it's a nod to Soundscape's Microsoft roots because of Windows services that have a "Delayed Start" even though the phrase is pretty generic at the same time.
On Fri, Nov 15, 2024 at 4:02 PM Daniel W. Steinbrook < @.***> wrote:
I agree that the "enter" is unnecessary. The reason it's there is because there's actually a second parameter in the code, Leave Vicinity Distance, but it's not configurable (it's calculated relative to the Enter Vicinity Distance). I think "Audio Mute Distance" is a good replacement.
— Reply to this email directly, view it on GitHub https://github.com/soundscape-community/soundscape/pull/129#issuecomment-2480172122, or unsubscribe https://github.com/notifications/unsubscribe-auth/BM5FVGT4NXRNKOSTPVEHX7L2A2DPVAVCNFSM6AAAAABRZLWAPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGE3TEMJSGI . You are receiving this because you commented.Message ID: @.***>
I've just changed the translation to "Audio Mute Distance." We shouldn't close this pull request until the changes show up in the Weblate fork. I'll let you know when that happens.
It looks like Weblate has just merged my changes into the Weblate fork. After merging this pull request, "Enter Vicinity Distance" will be officially changed to "Audio Mute Distance."
Translations update from Hosted Weblate for Soundscape/iOS app.
Current translation status: