soundscape-community / soundscape

An iOS application/service that aids navigation through spatialized audio
https://soundscape.services
MIT License
21 stars 22 forks source link

RFC: separating the tile service (svcs/data) into it's own repository. #69

Closed RDMurray closed 1 year ago

RDMurray commented 1 year ago

I think it would be a good idea to separate svcs/data into it's own repository, as it is mostly independent from the app, and it doesn't make sense to rebuild and test the app for commits to the tile service. Comments for and against welcome.

steinbro commented 1 year ago

The argument I find most compelling about keeping everything in one repo is that it's much harder to find yourself with incompatible checkouts of the server and app. If the primary complaint is that we're running CI unnecessarily, it looks like this could be fixed with path filters in the actions. Whatever we choose, we ought to add a rule to only run on changes to apps/ios/*.

wdturner commented 1 year ago

I tend to side with Daniel on this. I like everything to live together. It simplifies things downstream including for making it available to other potential developers.

All the best,

Wes

On Tue, Nov 7, 2023 at 6:50 PM Daniel W. Steinbrook < @.***> wrote:

The argument I find most compelling about keeping everything in one repo is that it's much harder to find yourself with incompatible checkouts of the server and app. If the primary complaint is that we're running CI unnecessarily, it looks like this could be fixed with path filters https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-paths in the actions. Whatever we choose, we ought to add a rule to only run on changes to apps/ios/*.

— Reply to this email directly, view it on GitHub https://github.com/soundscape-community/soundscape/issues/69#issuecomment-1800437034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUG726V33UAI6IENO77TWDYDLCL3AVCNFSM6AAAAAA7B3YU42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBQGQZTOMBTGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- --

RDMurray commented 1 year ago

Okay.