search

soundscape-community / soundscape

An iOS application/service that aids navigation through spatialized audio
https://soundscape.services
MIT License
21 stars 22 forks source link

Fix CI/CD #9

Closed steinbro closed 1 year ago

steinbro commented 1 year ago

I tried adding the default iOS build/test Githuib Actions template, but there's some customization needed. Adding the bundle install/pod install commands as documented didn't quite cut it -- we're getting some dependency conflicts.

https://github.com/openscape-community/openscape/actions/workflows/ios.yml

steinbro commented 1 year ago

This is passing now. I resolved the Bundler/CocoaPods issue, though I'm still not entirely sure why the additional step that installs a specific version of CocoaPods isn't redundant to the commands that were already there.

The Openscape app then builds in 12-15m.

I commented out the subsequent Test step, since we were getting the error "Scheme Openscape is not currently configured for the test-without-building action." I'm guessing the code did came with some automated tests to run, but we'll need to figure out how to properly invoke them.

So, I wouldn't consider this issue resolved. But we at least have a job now that validates on each commit that the app still compiles, which is worth something.

steinbro commented 1 year ago

Hmm, looking through the code, I do see some references to (disabled) tests, e.g. in apps/ios/GuideDogs.xcodeproj/xcshareddata/xcschemes/Openscape - Dogfood.xcscheme, but I don't see these tests actually implemented anywhere.

It would definitely be a good idea to have tests, but writing them anew is beyond the scope of just fixing the CI configuration. Marking this as complete for now.