search

sounisi5011 / package-version-git-tag

Add Git tag corresponding to the version field of package.json
MIT License
3 stars 5 forks source link

Add --remote option #64

Open sounisi5011 opened 5 years ago

sounisi5011 commented 5 years ago

There may be multiple remote repositories configured in Git. The name of the remote repository is often "origin", but this is not the default built in Git.

If remote repositories other than "origin" are set, the option to select them is required.

sounisi5011 commented 5 years ago

I agree that this feature is required. But do you need to add new options?

I think it's better to use the value of the --push option.

package-version-git-tag --push custom-remote
sounisi5011 commented 5 years ago

I agree that this feature is required. But do you need to add new options?

I think it's better to use the value of the --push option.

package-version-git-tag --push custom-remote

The --push option is a boolean option in previous versions. Allowing this option's value to be set can be confusing. And, We must also assume that you want to specify additional options for the git push command. Do beginners know that the value of the --push option indicates a remote? It's not intuitive.