Open illegalargumentexc opened 1 year ago
soup-bowl
commented
1 year ago It's best to rule out a setup bug before committing changes, as what might fix for one, might break for others. Cautious as I'm using the theme on Chicago95 currently without tab height issues. Looks like your screen is high density?
If you can drop some details about your environment (Firefox version, Operating System, theme, resolution) when I've got some time I can replicate it.
illegalargumentexc
commented
1 year ago I tried it on both my main macos host and on my voidlinux vm, it persisted in both cases, even with DPI changes
Host details:
macOS High Sierra 10.13.6 Mac Pro 5,1 (Early 2009) GPU: ATI Radeon HD 4870 CPU: 2 x Intel Xeon E5520 Memory: 20GB DDR3 DE: Aqua WM: Rectangle Resolution: 1920x1200 Browser: Librewolf 110.0-1
VM details:
OS: Void Linux Host: VirtualBox DE: xfce 4.18 WM: xfwm 4.18 Theme: Chicago95 Resolution: 1920x1200 Firefox Version: Firefox ESR 102.3.0
It could be a hardware issue with my GPU failing to render it, although opening more tabs and making the tab navigation buttons appear seems to fix it for as long as there are that many tabs open
soup-bowl
commented
1 year ago I tried it on both my main macos host [..]
FYI macOS isn't currently supported - the theme has a hard dependency on a present menubar, and there will be spacing issues due to the lack of one.
OS: Void Linux Host: VirtualBox DE: xfce 4.18 WM: xfwm 4.18 Theme: Chicago95 Resolution: 1920x1200 Firefox Version: Firefox ESR 102.3.0
Thanks for dropping your setup details - I'll try replicating it.
soup-bowl
commented
1 year ago Does it mysteriously disappear when you open customise, but once leaving it returns back to a gap? If so, I believe I've replicated the problem on my ESR copy. Appears fine on main build.
the tab height is cropped, i managed to fix it by changing the tab-newtab-button max-height in tabs.css to a higher value idk how to submit fixes or bugs i'm new to contributing