search

souporserious / react-measure

📏 Compute measurements of a React component.
https://souporserious.github.io/react-measure/
MIT License
1.94k stars 109 forks source link

Upgrade babel to beta #102

Closed TrySound closed 6 years ago

souporserious commented 6 years ago

Looks like there's a small conflict from the other PR. Curious why this isn't a dev dependency? 🤔 Sorry, I haven't been following the latest Babel releases 😇.

TrySound commented 6 years ago

Done.

souporserious commented 6 years ago

Thanks! What's the purpose of that living in dependencies? Does it add to the final bundle at all?

TrySound commented 6 years ago

babel runtime is dependency injected by babel by transform-runtime. It contains helpers and polyfills.

TrySound commented 6 years ago

It does not necessary add something, but what is added will be reused across packages.

souporserious commented 6 years ago

Sounds good, thanks!