souporserious / react-media-player

React audio and video player.
https://souporserious.github.io/react-media-player/
ISC License
470 stars 100 forks source link

chore(HTML5): break AudioObject to its own vendor #44

Closed dobrite closed 6 years ago

dobrite commented 6 years ago

Fixes unmounted Audio objects hanging around. It also cleans up all the conditionals in HTML5 and moves all the complexities of handling the audio object to its own component.

I inherited from HTML5. I'm open to a different way of code sharing, but I felt this was the most direct and understandable.

Before

media-player-broke

After

media-player-fixed

souporserious commented 6 years ago

So much cleaner! Thank you 🙏