search

souporserious / react-media-player

React audio and video player.
https://souporserious.github.io/react-media-player/
ISC License
470 stars 100 forks source link

Warning on componentWillUpdate #74

Open LeNiglo opened 5 years ago

LeNiglo commented 5 years ago

Hey there,

Really great library, working perfectly, no issues to report on my side. But React warns me about componentWillUpdate being renamed.

Here is the warning :

Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • Rename componentWillUpdate to UNSAFEcomponentWillUpdate to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: Player

Nothing to worry at the moment, but you will have to update to fix this 👍