search

sourabhtk37 / CodeShare

A django application for sharing code snippets.
GNU General Public License v3.0
3 stars 12 forks source link

Modified code for pep-8 standard #39

Closed theparadoxer02 closed 7 years ago

theparadoxer02 commented 7 years ago

Added unit-tests

sourabhtk37 commented 7 years ago

Have you checked whether the imports that you removed is really not required and webapp is working properly?

sourabhtk37 commented 7 years ago

If possible read about integrating Travis to run flake8 or other pep8 based plugin to automatically check for errors. Will be quite useful. Maybe checkout this

theparadoxer02 commented 7 years ago

yes i have checked that removed imports is not affecting the actual code.

On Sat, Jul 29, 2017 at 5:23 PM, T K Sourabh notifications@github.com wrote:

Have you checked whether the imports that you removed is really not required and webapp is working properly?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sourabhtk37/CodeShare/pull/39#issuecomment-318825371, or mute the thread https://github.com/notifications/unsubscribe-auth/AObic8eVbkkGg1NXu91n9Dphr_PvV5Q9ks5sSx0dgaJpZM4OnUtZ .

theparadoxer02 commented 7 years ago

i am using anaconda plugin in sublime-text as suggested by many. Is there still need to learn about flake or this is enough ?

sourabhtk37 commented 7 years ago

So, we need to have automatic builds and returns error if there are some pep8 errors on build results. The builds happens on Travis CI. For that you need to setup hooks from here to travis. We will be using Travis for running automated tests.

sourabhtk37 commented 7 years ago

Closing this as it's outdated.