souramoo / commentoplusplus

Commento with out of the box patches and updates to add useful features and fixes. Also with one-click deploy to Heroku so you can get up and running fast.
MIT License
389 stars 62 forks source link

Un-bundling included fonts #125

Open gibmat opened 2 years ago

gibmat commented 2 years ago

Currently commentoplusplus bundles several fonts in the frontend/fonts/ directory. I'd like to see if it's possible to un-bundle those fonts by depending on a nodejs package to dynamically pull them in at build time. My motivation is Debian packaging work -- I need to know the license/creator information for the fonts, and it will be much easier to package things if the fonts were not bundled with commentoplusplus but rather installed on their own from their actual upstream source.

Some sleuthing indicates that the fonts currently bundled are the Source Sans Pro fonts, as hosted by Google Fonts. The source project appears to be https://github.com/adobe-fonts/source-sans, which publishes a npm package. Admittedly I haven't done much with nodejs, but I hope it would be fairly easy to remove the bundled copy of the fonts, add a dependency on the source-sans nodejs package, and do any necessary CSS-fixup to reflect changes in filenames, etc.

Does that seem like something that could be done without too much trouble?