search

souramoo / commentoplusplus

Commento with out of the box patches and updates to add useful features and fixes. Also with one-click deploy to Heroku so you can get up and running fast.
MIT License
391 stars 63 forks source link

Web vitals errors #51

Closed TannerGabriel closed 3 years ago

TannerGabriel commented 3 years ago

First, thank you for all the work on the project. That said, I have found a few bugs/problems when running a website performance test that should be addressed.

Cross origin destination unsafe

This can be fixed by adding the named parameters to the a tag in this line. I could make a PR for this if that is ok with you.

The following error could be a bit harder to debug as it has something to do with WebSockets, but it is not easily reproducible when trying manually. Let me know if you have any ideas about this.

Socket errors

souramoo commented 3 years ago

Hey, Thanks for looking into this! I'd be more than happy to accept a PR for this :)

The websocket error is weird - I've tried to do a bit of research on it and it seems it's quite common and likely because the web.dev firewall blocks websocket connections during the test (https://stackoverflow.com/questions/59157106/unable-to-reproduce-web-dev-console-errors) but are safely ignored.

TannerGabriel commented 3 years ago

@souramoo If we can safely ignore the WebSockets errors, I see no problem in closing the issue.