search

souramoo / commentoplusplus

Commento with out of the box patches and updates to add useful features and fixes. Also with one-click deploy to Heroku so you can get up and running fast.
MIT License
391 stars 63 forks source link

Instructions for adding domains is incorrect #52

Open boxedpaul opened 3 years ago

boxedpaul commented 3 years ago

When adding a new domain, the instructions are as follows:

image

The instructions are incorrect. Prefixing your domain with %., e.g. %.example.com will not allow the variations listed. The domain name must still be prefixed with a ..

www.example.com.au and app.example.com would be allowed. example.com would not be allowed.

To allow example.com, the domain needs to be set up as %example.com.

However, when I tried this, www.example.com was no longer recognised, so I'm not sure if it's possible to have a single domain value that recognises all sub-domains and no sub-domain.

souramoo commented 3 years ago

Haha oops, this is definitely a bug from a recently added feature that could definitely do with some more testing rather than the instructions being incorrect - will investigate!

sarveshraj commented 3 years ago

Hey, @souramoo, firstly thanks a lot for maintaining this project. Is this bug something in consideration of being picked up? It affects us as well 😬 Would be happy to help if required

candideu commented 2 years ago

Is this still a bug?