search

souramoo / commentoplusplus

Commento with out of the box patches and updates to add useful features and fixes. Also with one-click deploy to Heroku so you can get up and running fast.
MIT License
391 stars 63 forks source link

Align golang version configuraiton #77

Closed olof-nord closed 2 years ago

olof-nord commented 2 years ago

In the root Dockerfile golang:1.15 is used.

This PR aligns the golang version specified in the GitLab CI, in the Circles CI, and for the backend itself.

Lastly it sets the GitLab CI git depth, which configures the CI to use shallow cloning, as it then only checks out the last 10 commits (at least in theory making the CI faster).

A small question: This project is using GitHub Actions, GitLab CI and CircleCI, all at the same time? If for example CircleCI isnt used, perhaps we can just remove the pipeline config.

https://docs.gitlab.com/ee/ci/runners/configure_runners.html#shallow-cloning

souramoo commented 2 years ago

Many thanks for this, merging!

To answer your question, gitlab CI was used by the original commento project but is not used by commentoplusplus, pending merging the functionality into github actions (as currently the releases are done manually by me but would like to automate this in the near future).

CircleCI is only used to pull updates from upstream but there haven't been any in years. I tried implementing this with github actions but there were some weird bugs in the github actions runner at the time that were solved by simply using circleci. Probably worth removing this now, or at least disabling it until the original commento project comes back to life.

Github actions is currently just used to deploy to docker hub but am keen on moving everything else onto it eventually :)

olof-nord commented 2 years ago

You got it. Ive got us a start with PR #84, setting up some initial build and test jobs.

As the original project has quite a tidy Makefile setup, it was quite manageable.