Patch: cmdline arguments, split tests into Tester.h

[GoogleCodeExporter]

Select tests to run from command line.

Move test definitions from main.cpp to Tester.cpp

Original issue reported on code.google.com by p...@mac.com on 2 Feb 2012 at 10:06

Attachments:

• cmdlineargs.diff

[GoogleCodeExporter]

You're patch is far too complex and contains much more than just the addition 
of command line argument parsing. To have any hope of the maintainer committing 
your changes you'd need to submit small single purpose patches. I count at 
lease 5 in your patch (tidies like removing unused variables, breaking tests 
into individual functions, extracting common code from tests that use 
CombonationKeyTest, adding argument parsing, bulk code move of tests into 
Tester.h). Also, always adopt the existing coding style in your patches.

For those interested I attach a patch the the bulk code move reversed so that 
the OPs code changes are at least visible in a visual diff. The patch file is 
still too complex to eyeball directly. I may come back later and further 
subdivide this patch.

Original comment by shane.a....@gmail.com on 4 Feb 2012 at 1:31

Attachments:

• cmdlineargs2.diff

[GoogleCodeExporter]

Yeah, this change is too big to incorporate in one go. I might add pieces of it 
in, so I'll leave this bug open for now.

Original comment by tanj...@gmail.com on 11 May 2012 at 6:24