source-academy / backend

Backend of Source Academy @ NUS, LMS extension of Source Academy (Elixir, Ecto, Phoenix, PostgreSQL)
https://sourceacademy.nus.edu.sg
Apache License 2.0
39 stars 50 forks source link

Grading Permissions #1161

Open GabrielCWT opened 1 month ago

GabrielCWT commented 1 month ago

Staff should only be able to grade submissions which are under their group. They are currently able to edit other people's gradings even though they are not part of that group.

martin-henz commented 1 month ago

It's a bit debatable, depending on the workflows we use. Sometimes we need Avengers to grade homework from other Studio groups. It's all tracked so this should be fine. I'm afraid we are restricting things and end up losing flexibility.

GabrielCWT commented 1 month ago

It's a bit debatable, depending on the workflows we use. Sometimes we need Avengers to grade homework from other Studio groups. It's all tracked so this should be fine. I'm afraid we are restricting things and end up losing flexibility.

Could you provide a use case for this? If you are an Avenger who is temporarily substituting someone else, shouldn't they be able to unsubmit/publish the assessments. Setting them as the group leader temporarily would allow them to grade, unsubmit and publish.

I feel that permissions should be standardised with regard to the grading process.

martin-henz commented 1 month ago

At the moment, all staff can participate in all grading. In that way it is "standardized". Sometimes Avengers fall behind in grading and we ask other Avengers to help out with the grading. That can be done without changing the configuration. I feel that if we track all actions in the backend, and make it transparent to students and staff who is making the changes, we can maintain maximal flexibility.

I feel it's a bit of a philosophical debate. Currently we perhaps err on the side of flexibility. Avenger assignment to student groups just changes the behaviour of the filters in the grading table to let them more easily find "their" students.

GabrielCWT commented 1 month ago

I will leave this open for others to input on this matter