source-academy / backend

Backend of Source Academy @ NUS, LMS extension of Source Academy (Elixir, Ecto, Phoenix, PostgreSQL)
https://sourceacademy.nus.edu.sg
Apache License 2.0
39 stars 50 forks source link

Unattempted questions in submissions should be marked graded #495

Open Aulud opened 5 years ago

Aulud commented 5 years ago

Unattempted questions in submissions should be marked graded

Request to update existing auto-submission feature.

Current behaviour

When an assessment closes, the backend auto-submits all student submissions, and inserts empty answers for any questions that were not attempted by the student. These empty answers have the answer string set to // Question not answered by student.

However, these empty answers are not treated as :graded for the purposes of the grading_status field, as it is computed by comparing the number of questions in a submission to the number of manual gradings for that submission found in the database.

Ideal behaviour

All empty answers are treated as :graded and the grading overview of submissions on the frontend appropriately reflects wholly unattempted assessments as fully graded.

martin-henz commented 5 years ago

Yes, that would be great!