source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)
https://sourceacademy.org
Apache License 2.0
102 stars 164 forks source link

Upgrade react-scripts #2313

Closed chownces closed 1 year ago

chownces commented 1 year ago

Alternatively,:

ianyong commented 1 year ago

This would also allow us to remove the following hack: https://github.com/source-academy/frontend/blob/46ade71e85c5dfcf478f906ed62201667c97aced/package.json#L133-L136

See #2214 for context.

ianyong commented 1 year ago

Unfortunately, we cannot upgrade react-scripts (CRA) to v5.0x because another dependency that we use, Create React App Configuration Override (CRACO) does not have a stable version that supports CRA v5.x yet

It seems that this is no longer true with the release of CRACO v7, so we might be able to fully resolve the issue in #2214 as well as update Node.js once we upgrade react-scripts.