source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)
https://sourceacademy.org
Apache License 2.0
101 stars 164 forks source link

Modify mobile keyboard to be scrollable #2915

Closed Johnwz123 closed 2 months ago

Johnwz123 commented 2 months ago

Description

Closes #2872

Modified mobile keyboard key selection. Previously, users had to click a button to cycle through rows of different sets of keys. Now, users scroll horizontally through a single row containing every key.

Type of change

How to test

  1. Access Source Academy either on a physical mobile device or use browser dev tools to shrink viewport dimensions to access mobile UI.
  2. Go to the Source Academy Playground page and expand the draggable keyboard on the right side of the screen.
  3. Attempt typing characters into the editor by scrolling to find and clicking the respective keys. Ensure key click is not registered while scrolling. (Note: Editor needs to be in focus (blinking cursor) to be able to type.)

Checklist

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8649923586

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/mobileWorkspace/MobileKeyboard.tsx 0 31 0.0%
<!-- Total: 0 31 0.0% -->
Totals Coverage Status
Change from base Build 8636747271: -0.04%
Covered Lines: 5199
Relevant Lines: 13793

💛 - Coveralls