Open CZX123 opened 7 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/features/cseMachine/tests/snapshots/CseMachineAnimation.tsx.snap | 0 | 1 | 0.0% | ||
src/features/cseMachine/components/ControlItemComponent.tsx | 1 | 2 | 50.0% | ||
src/features/cseMachine/components/StashItemComponent.tsx | 1 | 2 | 50.0% | ||
src/features/cseMachine/CseMachineUtils.ts | 3 | 5 | 60.0% | ||
src/features/cseMachine/components/Frame.tsx | 20 | 22 | 90.91% | ||
src/features/cseMachine/animationComponents/FrameCreationAnimation.tsx | 0 | 4 | 0.0% | ||
src/features/cseMachine/CseMachineAnimation.tsx | 1 | 7 | 14.29% | ||
src/features/cseMachine/CseMachineLayout.tsx | 5 | 11 | 45.45% | ||
<!-- | Total: | 66 | 89 | 74.16% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/features/cseMachine/CseMachineAnimation.tsx | 1 | 14.29% | ||
src/features/cseMachine/CseMachineLayout.tsx | 2 | 63.61% | ||
src/features/cseMachine/animationComponents/FrameCreationAnimation.tsx | 2 | 0.0% | ||
src/features/cseMachine/CseMachineUtils.ts | 3 | 69.03% | ||
<!-- | Total: | 8 | --> |
Totals | |
---|---|
Change from base Build 9984069378: | 0.6% |
Covered Lines: | 4979 |
Relevant Lines: | 14679 |
Description
This PR fixes some UI & animations issues, and add some tests for the CSE machine's layout and animations. Fixes #2921 fully by correctly calculating the width of the frame with a rune. Fixes #2959. Fixes #2716. The new result is shown below:
Changes
UI
:::pre-declared names:::
now should appear first, above all bindings_height
and_width
now only refer to the height and widths of the array boxes or closure circles onlyArrayValue
now has atotalHeight
andtotalWidth
property that stores the total height and width of nested values inside the arrayFnValue
andGlobalFnValue
has atotalWidth
property that also includes the tooltip widthAnimations
FrameCreationAnimation
BaseAnimationComponent
, so that the example below has the correct expected behavior:Testing
AnimationComponent