Migrate to Redux Toolkit part 6

[RichDom2185]

Description

Now that we are using the builder pattern, we can more easily split the code for better clarity and also better enforce some separation.

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update
• [x] Code quality improvements

How to test

Checklist

• [x] I have tested this code
• [ ] I have updated the documentation

[coveralls]

Pull Request Test Coverage Report for Build 8911594148

Details

• 243 of 323 (75.23%) changed or added relevant lines in 15 files are covered.
• 4 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.03%) to 33.067%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/commons/achievement/AchievementView.tsx	0	1	0.0%
src/commons/workspace/WorkspaceReducer.ts	6	7	85.71%
src/pages/academy/grading/subcomponents/GradingWorkspace.tsx	0	1	0.0%
src/commons/sagas/BackendSaga.ts	2	4	50.0%
src/features/playground/PlaygroundReducer.ts	4	7	57.14%
src/commons/mocks/BackendMocks.ts	0	4	0.0%
src/commons/workspace/reducers/editorReducer.ts	136	143	95.1%
src/commons/application/reducers/SessionsReducer.ts	17	29	58.62%
src/commons/workspace/reducers/cseReducer.ts	5	21	23.81%
src/features/stories/StoriesReducer.ts	2	35	5.71%
<!--	Total:	243	323	75.23%	-->

Files with Coverage Reduction	New Missed Lines	%
src/commons/workspace/WorkspaceReducer.ts	2	79.87%
src/features/stories/StoriesReducer.ts	2	13.95%
<!--	Total:	4		-->

Totals
Change from base Build 8798229512:	-0.03%
Covered Lines:	5299
Relevant Lines:	14893

---

💛 - Coveralls

[JoelChanZhiYang]

It looks good! The naming of "multiFileReducer" might be a bit confusing to people newer to Source Academy. I would not explicitly separate the multi-file and the single file (since the single file is simply a subset of the multi-file).

I would just call it the editorReducer.

Some parts of the multiFileReducer would be good contenders for a future refactor. It seem strange that cursor location is stored in global state.

[chownces]

Debugged and fixed the failing tests following the RTK migration as discussed offline with @RichDom2185

Analysis:

• RTK discourages the use of non-serializable structures like Map due to use of the Immer library
• As a result, the map data structures in the redux store were frozen
• The lodash.merge operation in createStore.ts fails silently when it is unable to merge in the new map
• Thus, the mock store.session.assessments was an empty default map, resulting in the snapshots failing

Solution:

• Use the default JS object which is serializable
• This is somewhat ok with TS now supporting compile time checks on types like { [id: number]: Assessment } even though JS object keys are string

Misc.

• Also added await to the backend saga tests to ensure that the redux-saga-test-plan tests were actually running to completion