source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)
https://sourceacademy.org
Apache License 2.0
101 stars 164 forks source link

Migrate out of react-hotkeys to @mantine/hooks #2968

Closed chownces closed 1 month ago

chownces commented 2 months ago

Description

Consolidating our usage of 3rd party hooks under the mantine hooks library.

‼️ BREAKING CHANGE

Closes #2935

Type of change

How to test

Checklist

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8934209129

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/sideContent/content/SideContentDataVisualizer.tsx 2 6 33.33%
src/commons/sideContent/content/SideContentSubstVisualizer.tsx 33 73 45.21%
<!-- Total: 43 87 49.43% -->
Files with Coverage Reduction New Missed Lines %
src/commons/sideContent/content/SideContentSubstVisualizer.tsx 2 37.78%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 8934207535: 0.2%
Covered Lines: 5319
Relevant Lines: 14850

💛 - Coveralls
RichDom2185 commented 2 months ago
  • [ ] Migration of SideContentTabs: CseMachine, ~SubstViz~, DataViz

Note that we plan to shift DataViz to a module: #2809