source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)
https://sourceacademy.org
Apache License 2.0
103 stars 167 forks source link

Bump ESLint and related dependencies #2986

Closed RichDom2185 closed 6 months ago

RichDom2185 commented 6 months ago

Description

Closes #2973. Refer to the linked issue for details.

eslint-plugin-react-refresh is a newly installed plugin that will ease our migration to Vite. We install the canary version as the stable version that supports ESLint v9 will only be released alongside React 19.

Also added TODOs to eventually make the code quality stricter.

Type of change

How to test

yarn eslint works.

Checklist

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8959901428

Details


Files with Coverage Reduction New Missed Lines %
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentDeploymentTab.tsx 1 0.0%
src/commons/XMLParser/XMLParserHelper.ts 1 0.0%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 8959899390: 0.0%
Covered Lines: 5146
Relevant Lines: 14691

💛 - Coveralls
RichDom2185 commented 6 months ago

As expected, CRA makes the dev experience a nightmare…

image

It's using an old version of ESLint which makes it incompatible. I think we should disable ESLint in the dev server and let us handle the linting separately.