coveralls
commented
6 months ago Pull Request Test Coverage Report for Build 8971775169
Details
- 59 of 152 (38.82%) changed or added relevant lines in 35 files are covered.
- 3 unchanged lines in 3 files lost coverage.
- Overall coverage decreased (-0.03%) to 32.11%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/commons/application/Application.tsx | 0 | 1 | 0.0% | ||
| src/commons/application/reducers/CommonsReducer.ts | 2 | 3 | 66.67% | ||
| src/commons/editingWorkspace/EditingWorkspace.tsx | 0 | 1 | 0.0% | ||
| src/commons/notificationBadge/NotificationBadge.tsx | 0 | 1 | 0.0% | ||
| src/commons/profile/Profile.tsx | 1 | 2 | 50.0% | ||
| src/commons/utils/CToWasmHelper.ts | 0 | 1 | 0.0% | ||
| src/commons/utils/SourcerorHelper.ts | 0 | 1 | 0.0% | ||
| src/features/sourceRecorder/sourcecast/SourcecastReducer.ts | 17 | 18 | 94.44% | ||
| src/features/sourceRecorder/sourcereel/SourcereelReducer.ts | 19 | 20 | 95.0% | ||
| src/pages/academy/grading/Grading.tsx | 0 | 1 | 0.0% | ||
| <!-- | Total: | 59 | 152 | 38.82% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/pages/sourcecast/Sourcecast.tsx | 1 | 0.0% | ||
| src/pages/academy/sourcereel/Sourcereel.tsx | 1 | 0.0% | ||
| src/pages/academy/adminPanel/subcomponents/NotificationConfigPanel.tsx | 1 | 0.0% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 8971758895: | -0.03% |
| Covered Lines: | 5011 |
| Relevant Lines: | 14652 |
RichDom2185
Description
To rebase and merge onto
masteronce #2988 is merged.Mainly a PR to clean up things, but also migrated to RTK for Sourcecast and Sourcereel reducers.
Removes the compatibility layer of having named exports for every action creator. This forces callers to use the default export (and also fully qualified names) of the actions they want to dispatch. Hopefully, this will reduce the chances of any name conflicts, and also enforce better abstractions and grouping of the individual actions. Currently, I feel that some action creators don't belong in the correct file. By forcing the usage of the fully qualified name (especially as the number of actions keeps increasing), people might think twice before putting an action creator inside a specific file.
Technically a breaking change.
Type of change
How to test
I just changed the imports, without any implementation change (except for the migration of
GitHubPersistenceSagato use the new helper) – so it should be a non-issue.Checklist