Refactor game simulator

source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)

https://sourceacademy.org

Apache License 2.0

103 stars 167 forks source link

Refactor game simulator #2997

Closed RichDom2185 closed 6 months ago

RichDom2185 commented 6 months ago

Description

Fixes a runtime error when using Vite due to CheckpointTransition and GameManager instantiation before the game simulator instance is initialised.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Code quality improvements

How to test

Checklist

[x] I have tested this code
[ ] I have updated the documentation

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 9068697512

Details

0 of 9 (0.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 31.41%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/features/gameSimulator/GameSimulatorConstants.ts	0	1	0.0%
src/pages/academy/gameSimulator/GameSimulator.tsx	0	8	0.0%
<!--	Total:	0	9	0.0%	-->

Totals
Change from base Build 9068691530:	-0.002%
Covered Lines:	4891
Relevant Lines:	14671

💛 - Coveralls

RichDom2185 commented 6 months ago

Fixes a runtime error when using Vite

I just realised the runtime error also occurs now when using CRA. Must have been a regression when the router is refactored.