source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)
https://sourceacademy.org
Apache License 2.0
103 stars 167 forks source link

Refactor academy navigation bar #2998

Closed RichDom2185 closed 6 months ago

RichDom2185 commented 6 months ago

Description

By moving the rendering logic to use conditional rendering instead of CSS classes, we can ensure correct margin behaviour (as the margin is dependent on the whether a child exists).

Ideally, we remove the old flexbox-grid dependency as well in the future.

image

Also refactored to use components instead of render functions.

Refer to commit history for more detailed list of changes.

Also resolves (partially) #2722.

Type of change

How to test

Checklist

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 9062394319

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/navigationBar/NavigationBar.tsx 11 27 40.74%
<!-- Total: 20 36 55.56% -->
Totals Coverage Status
Change from base Build 9062386750: -0.02%
Covered Lines: 4943
Relevant Lines: 14716

💛 - Coveralls