Create NUS login page - Githubissues

source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)

https://sourceacademy.org

Apache License 2.0

103 stars 167 forks source link

Create NUS login page #3016

Closed RichDom2185 closed 3 months ago

RichDom2185 commented 3 months ago

Description

As per title. For compliance with requirements.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

Checklist

[x] I have tested this code
[ ] I have updated the documentation

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10341884262

Details

11 of 38 (28.95%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 31.716%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/pages/login/LoginPage.tsx	2	3	66.67%
src/routes/routerConfig.tsx	1	3	33.33%
src/commons/utils/Constants.ts	8	19	42.11%
src/pages/login/NusLogin.tsx	0	13	0.0%
<!--	Total:	11	38	28.95%	-->

Totals
Change from base Build 10340093783:	-0.02%
Covered Lines:	4822
Relevant Lines:	14372

💛 - Coveralls