source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)
https://sourceacademy.org
Apache License 2.0
103 stars 167 forks source link

Add tooltip for assessments that are not fully attempted #3028

Closed josh1248 closed 2 months ago

josh1248 commented 3 months ago

Description

Type of change

Resolves https://github.com/source-academy/frontend/issues/2231 by implementing the required UI improvement:

image

josh1248 commented 3 months ago

Hmm, are the snapshot fails to be expected?. I am not too sure about how to update snapshots as required.

RichDom2185 commented 2 months ago

Hmm, are the snapshot fails to be expected?. I am not too sure about how to update snapshots as required.

Yes, they are (since you changed a button to a tooltip). yarn test --updateSnapshots (as per the README)

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10650958643

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/assessment/Assessment.tsx 1 2 50.0%
<!-- Total: 1 2 50.0% -->
Files with Coverage Reduction New Missed Lines %
src/commons/sideContent/content/SideContentCseMachine.tsx 3 39.81%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 10641831499: -0.03%
Covered Lines: 4851
Relevant Lines: 14542

💛 - Coveralls