source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)
https://sourceacademy.org
Apache License 2.0
103 stars 167 forks source link

Transfer groundControl from staff to admin route #3043

Closed josh1248 closed 2 months ago

josh1248 commented 2 months ago

Description

Addresses #3031 by re-routing ground control from a staff to an admin route. P.S.: still figuring out the backend. Will further changes be required?

Type of change

How to test

Checklist

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 11008345446

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/academyRoutes.tsx 0 2 0.0%
<!-- Total: 0 2 0.0% -->
Totals Coverage Status
Change from base Build 11007946528: 0.0%
Covered Lines: 4852
Relevant Lines: 14547

💛 - Coveralls
RichDom2185 commented 2 months ago

Waiting for the BE PR before merging.

josh1248 commented 2 months ago

@RichDom2185 backend PR is ready now. I have replaced all non-dangerous routes to use a "/staff" instead of "/admin" URL to connect to the backend. I have also changed the routes in the backend directly. All seems good, but I am not sure if I have advertently broken some frontend-backend link. Any automated way to test it?

RichDom2185 commented 2 months ago

Any automated way to test it?

@josh1248 not really, I think best to just not touch it. Refer to my comments above.

Basically your endpoints paths should be related to your resource.

E.g. GET /users/{id}/name

or something like that