search

source-academy / java-slang

Implementation of the Java language in TypeScript
Apache License 2.0
0 stars 0 forks source link

ECE - Evaluate FieldDeclaration and MethodInvocation #19

Closed xyliew25 closed 4 months ago

xyliew25 commented 5 months ago

Check commits.

xyliew25 commented 5 months ago

@1001mei do you mind reviewing the changes done to ast? I added some tests for the parser too.

Also, I'm so sorry for committing your commits, I must have messed up during rebasing and I'm not sure how to undo...

1001mei commented 4 months ago

@1001mei do you mind reviewing the changes done to ast? I added some tests for the parser too.

Also, I'm so sorry for committing your commits, I must have messed up during rebasing and I'm not sure how to undo...

Sure, no worries.

xyliew25 commented 4 months ago

@1001mei I understand that there may be unnecessary complexities involved since the different components, i.e., type checker, compiler, ECE, require a simpler/more complicated AST structure. Hope these changes are not too disruptive.

1001mei commented 4 months ago

Ya, I understand that each component might have different requirements on the AST structure. These changes do not affect the compiler too much, so feel free to merge them, I am totally fine with it.