source-academy / js-slang

Implementations of sublanguages of JavaScript, TypeScript, Scheme and Python
https://source-academy.github.io/source/
Apache License 2.0
70 stars 104 forks source link

Bump NodeJS to version 20 #1513

Closed RichDom2185 closed 10 months ago

RichDom2185 commented 10 months ago

Node 16 is EOL and Node 18 has build problems, but Node 20 seems to work fine and all tests pass locally on my MacBook.

TODOs:

coveralls commented 10 months ago

Pull Request Test Coverage Report for Build 7593133001


Totals Coverage Status
Change from base Build 6702227868: 0.08%
Covered Lines: 10893
Relevant Lines: 12706

💛 - Coveralls
RichDom2185 commented 10 months ago

Looks good! Let's have this merged and ready ASAP so that it becomes easier to setup with the same node version as the frontend.

Great, thanks! I've updated (and reformatted) the README as well, will merge after the CI passes.