source-academy / js-slang

Implementations of sublanguages of JavaScript, TypeScript, Scheme and Python
https://source-academy.github.io/source/
Apache License 2.0
70 stars 104 forks source link

1588 accidental unpacking during evaluating the if statement #1601

Closed FYL2003 closed 7 months ago

FYL2003 commented 8 months ago

Before this change, the if statement inside a block statement is not value producing, details in the following video https://github.com/source-academy/js-slang/assets/97390773/d1300c04-df1f-4f9c-8a50-9b0dcabe3d69

After the change, the if statement inside a block statement is value producing and will not accidentally unpack itself.

https://github.com/source-academy/js-slang/assets/97390773/c39527cb-06f1-4e5a-ae9e-bce52a26577e

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8402643535

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stepper/stepper.ts 0 6 0.0%
<!-- Total: 0 6 0.0% -->
Totals Coverage Status
Change from base Build 8402031014: 0.03%
Covered Lines: 10503
Relevant Lines: 12562

💛 - Coveralls