source-academy / js-slang

Implementations of sublanguages of JavaScript, TypeScript, Scheme and Python
https://source-academy.github.io/source/
Apache License 2.0
66 stars 104 forks source link

Added testing for pylib #1624

Closed JJtan2002 closed 6 months ago

JJtan2002 commented 6 months ago

Added test cases for pylib. Added type safety by throwing errors for invalid argument types for binary operators in pylib.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8509705972

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stdlib/pylib.ts 45 65 69.23%
<!-- Total: 45 65 69.23% -->
Totals Coverage Status
Change from base Build 8509696118: 0.1%
Covered Lines: 10691
Relevant Lines: 12722

💛 - Coveralls
sayomaki commented 6 months ago

Another quick nitpick about the code changes, is there any reason why we are not using strict equality when checking the types?

JJtan2002 commented 6 months ago

Another quick nitpick about the code changes, is there any reason why we are not using strict equality when checking the types?

There isn't actually, we'll do a quick change. Thank you for all the help!