source-academy / js-slang

Implementations of sublanguages of JavaScript, TypeScript, Scheme and Python
https://source-academy.github.io/source/
Apache License 2.0
66 stars 104 forks source link

Update git submodules to use relative paths #1669

Closed sayomaki closed 5 months ago

sayomaki commented 5 months ago

As mentioned in the discussion group, ssh users who clones the js-slang repo may face issues when checking out submodules (i.e. py-slang and scm-slang) if their https credentials are not yet properly set up. Thus, to better cater to both demographics (users cloning via the https:// protocol and users cloning via the ssh:// protocol), it would be better to use relative paths instead.

The reason why the relative path is set to traverse 2 level up (and then back with the source-academy prefix) is so that user forks will not be affected (as only going 1 level up will result in git trying to find a fork of the two repos py-slang and scm-slang under users' own account, which may or may not exist, and could be not the most updated version either).

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8657038476

Details


Totals Coverage Status
Change from base Build 8657000059: 0.0%
Covered Lines: 10767
Relevant Lines: 12788

💛 - Coveralls