source-academy / js-slang

Implementations of sublanguages of JavaScript, TypeScript, Scheme and Python
https://source-academy.github.io/source/
Apache License 2.0
66 stars 104 forks source link

Make Python operations stricter about types #1708

Closed Fidget-Spinner closed 3 months ago

Fidget-Spinner commented 4 months ago

Description

Fixes https://github.com/source-academy/py-slang/issues/39

Type of change

How to test

The example given in the issue should throw error now.

Checklist

RichDom2185 commented 4 months ago

The tests seem to be failing?

Fidget-Spinner commented 4 months ago

I think the tests should pass now

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9338381529

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stdlib/pylib.ts 14 96 14.58%
<!-- Total: 14 96 14.58% -->
Files with Coverage Reduction New Missed Lines %
src/stdlib/pylib.ts 35 44.2%
<!-- Total: 35 -->
Totals Coverage Status
Change from base Build 8967380994: -0.6%
Covered Lines: 10933
Relevant Lines: 13042

💛 - Coveralls
Fidget-Spinner commented 4 months ago

I need an approving review to merge it seems.

RichDom2185 commented 3 months ago

I need an approving review to merge it seems.

The CI turned out to fall, that's why I dismissed my approval

Fidget-Spinner commented 3 months ago

@RichDom2185 CI passes now.