search

source-academy / modules

Modules that can be imported by programs in Source Academy, an online experiential environment for computational thinking
Apache License 2.0
8 stars 28 forks source link

[CURVE]: Cyclic imports #145

Open Cloud7050 opened 2 years ago

Cloud7050 commented 2 years ago

The linter is reporting cyclic imports between bundles/curve/curves_webgl.ts and bundles/curve/types.ts.

The latter defines the types DrawMode, ScaleMode, and CurveSpace, which are used in the former, but at the same time, the former builds up to defining Curve and CurveDrawn, which the latter needs. Some refactoring may be in order, to resolve this and better fit each file's purpose.

martin-henz commented 5 months ago

The curve module will be replaced by plotly. We can remove curve once all missions/quests are migrated. We can then close this issue.

RichDom2185 commented 5 months ago

The curve module will be replaced by plotly. We can remove curve once all missions/quests are migrated. We can then close this issue.

Should we remove it? We can migrate to plotly for sure but I think it's worth keeping the "legacy" modules

martin-henz commented 5 months ago

Yes, we can keep curve around. No need to rush removal.