source-academy / modules

Modules that can be imported by programs in Source Academy, an online experiential environment for computational thinking
Apache License 2.0
8 stars 28 forks source link

#284: Fix REPL crashing #301

Closed JoelChanZhiYang closed 5 months ago

JoelChanZhiYang commented 5 months ago

Description

Fix the REPL crashing #284

Fixes # (issue) I changed the import of the react-ace. There seems to be a comment about how this method would not work but it works ok for me. Reviewer, please double check.

image

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

I checked that it worked locally

Checklist:

leeyi45 commented 5 months ago

Originally we needed the require import. But maybe at some point bumping versions of React, NodeJS, Esbuild or something else fixed this issue. I did ask Zihan to check if this issue was resolved before, but I guess it is definitely resolved now. LGTM.