source-academy / modules

Modules that can be imported by programs in Source Academy, an online experiential environment for computational thinking
Apache License 2.0
8 stars 28 forks source link

Tabs should detect if WebGL is disabled #321

Open yockcheng opened 3 weeks ago

yockcheng commented 3 weeks ago

Attempt to run code in playground for Studio 3 In-Class Studio Sheet causes website to crash.

Code Error
RichDom2185 commented 3 weeks ago

Not a bug. Please enable WebGL in the browser.

martin-henz commented 3 weeks ago

But should the frontend crash? Any way to check if webgl is enabled?

RichDom2185 commented 3 weeks ago

But should the frontend crash? Any way to check if webgl is enabled?

I don't think it should be handled by frontend. Should be handled by modules, since that's what's causing the render to fail

RichDom2185 commented 3 weeks ago

i.e., the tab should render the error message