source-academy / py-slang

Python sublanguage for SICP
Apache License 2.0
0 stars 0 forks source link

Tokenizer: Need to handle unindented blank lines within blocks #2

Closed Fidget-Spinner closed 1 year ago

Fidget-Spinner commented 1 year ago

The following perfectly valid Pytho code leads the tokenizer/scanner to create wrong tokens:

def foo():
    pass

    pass

To fix this, we should see how CPython solves it. I suspect it keeps track of a stack of indents/dedents.

Fidget-Spinner commented 1 year ago

Fixed by https://github.com/source-academy/py-slang/commit/1587bd56d80efdc061bdae7ce8b364e7f06a7284