source-foundry / FSCW

Toolkit to create Windows desktop setups for fonts.
MIT License
12 stars 6 forks source link

Inno Setup Compiler – "[ISPP] Error: Unable to read font name for entry 3." #8

Open thundernixon opened 5 years ago

thundernixon commented 5 years ago

I'm trying to use FSCW to test versions of the Inter font project.

My configuration is at https://github.com/thundernixon/FSCW.

Unfortunately, when I build with Inno Setup Compiler, I get the following error:

"[ISPP] Error: Unable to read font name for entry 3."

image

This seems like a basic thing to solve, but I'm pretty outside of my familiar territory with this tool. I've edited the version number, changed the font name, and tried to follow both the basic example and the Hack Installer example, but to no avail. What might I try next?

texhex commented 5 years ago

Your Data.ini looks good to me with one exception at the end, in the [InstallFonts] section.

The original file installed four font files, yours only two so the Count property needs to be changed to read like this on line 82

Count=2

Because there is no File.3 entry, FCSW shows the error. But you are right, this message isn't helpful at all if you do not have any idea of the inner working.

I will think about how I could implement a sanity check that would give you a detailed error that the Count and File.X entries do not match.

thundernixon commented 5 years ago

Ahh, I'm glad it was such an easy fix! Ha, I guess I mentally skipped right over that part. Thanks for pointing me in the right direction!

chrissimpkins commented 5 years ago

👍👍👍

chrissimpkins commented 5 years ago

@thundernixon if there is a way to make this more intuitive so that it is easier to implement Michael's Win installer in other projects let us know.

chrissimpkins commented 5 years ago

@texhex is it simple to implement the Appveyor based release pushes of installer builds from font files that are pushed by git commit Michael?

texhex commented 5 years ago

@thundernixon You're welcome. I will keep this issue open until I have implemented a better error message.

@chrissimpkins I'm sorry, I don't catch your meaning right now?

chrissimpkins commented 5 years ago

@texhex sorry I was on my phone and couldn't see the README at the time. You have it documented!

@thundernixon Stephen if you want to tie this into Appveyor CI for automated Win installer builds with Michael's tool here, his instructions are here https://github.com/source-foundry/FSCW#building-using-appveyor. He has this set up for our testing installer and it works extremely well. You push new font files via new git commit + git push and your remote GH repo -> Appveyor CI automatically builds the *.exe installer and pushes it as a release to the repository. Here is the release thread that shows all builds that resulted from git pushes to the repository:

https://github.com/source-foundry/Hack-Test-Win-Installer/releases

I love this approach. :)

chrissimpkins commented 5 years ago

@thundernixon the other thing that we've done is add a Python script to modify the name of the test files that are pushed to the path [ORIGINAL FAMILY NAME] Dev.ttf so that we can install them side-by-side for testing with release versions. He has this automated as part of the *.exe installer workflow as well.

thundernixon commented 5 years ago

Ohh wow, @chrissimpkins, that sounds even better than the Inno Setup Compiler!

I found Inno to be quite simple, once I got past my typo. :) Now, my VMware Windows device is basically refusing to work, but there's a good chance it's caused by something else.

That sounds pretty nice with the different names, however. It occurred to me this morning that name changes are probably the easiest and clearest way of knowing that something has actually been updated, and doesn't cause a problem if it's on a test machine, anyway.

chrissimpkins commented 5 years ago

@thundernixon

It occurred to me this morning that name changes are probably the easiest and clearest way of knowing that something has actually been updated, and doesn't cause a problem if it's on a test machine, anyway

https://github.com/chrissimpkins/fontname.py

texhex commented 5 years ago

@thundernixon Well, AppVeyor is using InnoSetup to create the setup file, so only when you have a working Inno/FSCW script, you can use that approach. You have to work your way through at least once ;).

The general procedure is described in the repo here, and the AppVeyor build file that also renames the fonts is over at the Hack Test Installer.

thundernixon commented 5 years ago

only when you have a working Inno/FSCW script, you can use that approach. You have to work your way through at least once

Oh, makes sense! That's a handy ordering in the readme setup, then. One slight suggestion: it might be worth specifying that in the AppVeyor steps, with this line:

• Perform the steps described in How to use it

Thanks for all the helpful info! I think this will come in handy on an upcoming project, especially.

texhex commented 5 years ago

Alright, I have tried to specify this in README.md.