search

source-foundry / Hack

A typeface designed for source code
http://sourcefoundry.org/hack/
Other
16.45k stars 615 forks source link

Watch Symbol - ⌚ (0x231A) #127

Open hut8 opened 9 years ago

hut8 commented 9 years ago

Hey! Hack supports Powerline, right? Powerline uses ⌚, at least for the tmux plugin, right before the time. I can't get it to work on any font in PuTTY and Hack is my new favorite font, so I'm hoping I'm missing something. I'm using the latest version.

chrissimpkins commented 8 years ago

This is not part of the main Powerline set but something we can consider. Noted.

mynetx commented 8 years ago

Suggestion:

bildschirmfoto 2015-10-13 um 16 29 21
chrissimpkins commented 8 years ago

@hut8 Liam, can you point us to some documentation about the Powerline branch that you are using?

@jublo That looks great. Nice work

hut8 commented 8 years ago

@chrissimpkins thanks for the prompt reply. I'm using the latest release of powerline. Here's the file where the character is defined: https://github.com/powerline/powerline/blob/develop/powerline/config_files/themes/powerline.json

Thanks.

chrissimpkins commented 8 years ago

Did you set a Powerline theme? This page indicates that there are themes available and they are configured with the JSON that you linked:

https://powerline.readthedocs.org/en/latest/configuration.html

I wasn't aware that there are themes available. The main Powerline status line glyph set includes those in these screenshots.

https://powerline.readthedocs.org/en/latest/overview.html#vim-statusline

Let me do a bit more reading up on the themes that are available. We will unfortunately need to draw the line somewhere with application specific glyph sets (particularly for glyph subsets that are theme specific). Having said that, we have something in the works that will address issues like this and this would be a perfect case for it (poke @burodepeper).

Much more news soon.

hut8 commented 8 years ago

That's actually how it comes out of the box (with the Powerline theme). The screenshot that you referenced is for using Powerline in Vim -- I'm using it in tmux.

I spent way too many hours yesterday going through every font that's patched for Powerline, and none of them seem to have this! So this would give Hack a big edge :)

chrissimpkins commented 8 years ago

can you post a screenshot with the glyph in context (along with any others that we would need to support for tmux)?

hut8 commented 8 years ago

This is the only glyph that seems to be missing from the default setup. There are a few others, and I can make a list, but this is the only one that is displayed with the default install. tmux with powerline

chrissimpkins commented 8 years ago

Thank you very much. I appreciate it. Sorry for my ignorance about this. I am not a Powerline user and haven't come across the UI with this glyph in the past. The default patch set that they release does not include this glyph.

It looks like @jublo already has a design ready for you (see above). Give us some feedback about it and we will see about getting it into an upcoming release. We currently release Powerline glyphs in the regular set, they are not included in italic or bold variants. Is there any need for bold or italic versions of this?

lrvick commented 8 years ago

Same issue for me, tmux latest powerline, default theme (pip install --user powerline-status) only the lock glyph does not render properly for me either. (though the lock glyph in zsh for some reason does?)

foo

lrvick commented 8 years ago

also +1 on @jublo 's lock design

chrissimpkins commented 8 years ago

also +1 on @jublo 's lock design

I agree it looks great

chrissimpkins commented 8 years ago

@lrvick These are the current Powerline glyphs included in Hack:

powerline-glyphs

We do include the lock glyph. These are mapped to the Unicode private use area as defined in the Powerline documentation. They are only included in the regular Hack set. Is it possible that tmux is attempting to display bold glyphs? This would explain why it would appear to be missing, something that we can definitely address.

lrvick commented 8 years ago

@chrissimpkins Yep, it is bold. Shows up as glyph e0a2 for me.

lrvick commented 8 years ago

bump. Any ideas on how to add these bold glyphs? I could take a stab at it myself if it is not too crazy.

chrissimpkins commented 8 years ago

@jublo you willing to contribute the watch outlines? I don't have these. I believe you only pushed an image from the editor.

chrissimpkins commented 8 years ago

@Irvick you just need bold variants of the current set of Powerline glyphs that we include in the regular set or you need the watch glyph as well?

mynetx commented 8 years ago

@chrissimpkins I’ll take a look at where I have them. I thought the watch was already merged… unsure

mynetx commented 8 years ago

@chrissimpkins @lrvick Please look here: https://github.com/jublonet/Hack/tree/feature/127-watch

lrvick commented 8 years ago

lock and clock are both missing for me with default powerline tmux config.

chrissimpkins commented 8 years ago

@jublo Thank you very much JM

chrissimpkins commented 8 years ago

@Irvick do you have a font editor?

lrvick commented 8 years ago

@chrissimpkins I do not. Any open source ones that run on Linux you can recommend? Google gives me a pretty daunting list. Fontforge looks interesting...

chrissimpkins commented 8 years ago

@lrvick FontForge is free, open source, and excellent. It is available on Linux. @davelab6 and crew have written a fantastic set of docs to support those who are getting started. Definitely check it out if you're interested.

https://fontforge.github.io/en-US/

Let me know if there is anything that I can do on my end to help if you decide to attack this issue.

mynetx commented 7 years ago

@lrvick @chrissimpkins What about the PR for this – is it useful or should it be altered?

chrissimpkins commented 7 years ago

Possibly useful to some, but not high priority according to our design objectives. Always welcome new glyph contributions but may not be something that we immediately merge. Also something that could be added to a separate glyph repository for optional compilation into the sets. I would favor the latter approach if we can get such a repository up and running with an approach that supports it. There is a great deal of expansion that we could accomplish with such a repository (variants of existing glyphs, brand new extended glyph sets, etc) that would be of benefit to subsets of users.