search

source-foundry / Hack

A typeface designed for source code
http://sourcefoundry.org/hack/
Other
16.4k stars 615 forks source link

Fallback mechanism for the woff/woff2 dependencies #403

Closed paride closed 6 years ago

paride commented 6 years ago

If sfnt2woff-zopfli and woff2_compress binaries are not found in the installation directory targeted when the scripts are called with --install-dependencies, then look if the binaries are installed system-wide (i.e., in the $PATH).

IR #395.

chrissimpkins commented 6 years ago

In light of @anthrotype's excellent suggestion to establish reproducible builds from a Python build dependency standpoint and my desire to make this the case across all build dependencies, let's move this to a separate script with a new make target rather than creating a new build path that is determined by the presence of system wide installs of these web font build dependencies. I am happy to support this here but we should not make this the default if reproducible builds are to be a goal going forward. This PR proposal takes us in the opposite direction and is probably best suited for a new make target that is explicitly requested by the builder and is not the project build make target default.

To support this, I need to change the current approach for both Python dependencies and ttfautohint as currently defined in the dependency install scripting.

I am going to postpone the remaining planned design objectives for the v3.003 release and we will push this transition in our build chain as the last set of changes that we will make before we release the existing dev branch changes as v3.003. I will create a branch off of dev where we can work on this and will rebase this PR on that branch.

chrissimpkins commented 6 years ago

Rebased this PR on the build-scripting branch where the build scripting work for outstanding v3.003 milestone IR work will occur. Added this PR to the v3.003 milestone.

chrissimpkins commented 6 years ago

Modified your OP to prevent automated closure of the associated issue report. I am going to merge this and use it as a basis for the script updates. This work will likely wind up on a different script path. Still trying to decide on the approach. Let's leave this open to continue the work. I will take care of the necessary changes to support the new make targets and the needs included in the work here will be part of those new targets.

chrissimpkins commented 6 years ago

Current work in https://github.com/source-foundry/Hack/pull/416 invalidates this PR. If you are interested in performing any of the work to support the remaining open build source refactor items that remain open in #416, please open a new PR. Thanks Paride.