search

source-foundry / Hack

A typeface designed for source code
http://sourcefoundry.org/hack/
Other
16.39k stars 613 forks source link

Added ruble Ruble sign U+20BD #430

Closed pkolchanov closed 6 years ago

pkolchanov commented 6 years ago

macOS retina

image
chrissimpkins commented 6 years ago

Looks great Pavel! Will add this on for our upcoming v4.000 release. Thanks for this contribution!

chrissimpkins commented 6 years ago

And ignore the test failure. I need to look into the pipenv issue with our Python script testing. It is unrelated to this commit/these changes.

chrissimpkins commented 6 years ago

Pavel, can I please have you confirm that these designs are your own work and that you are willing to contribute them to this project under the existing MIT license?

pkolchanov commented 6 years ago

Yes, sure.

chrissimpkins commented 6 years ago

Yes = these are your designs

Sure = MIT is OK?

Sorry but I need to confirm licensing issues if there are upstream for these designs, including DejaVu.

pkolchanov commented 6 years ago

These are my designs and I am willing to contribute them to this project under the MIT license

chrissimpkins commented 6 years ago

Thanks! Will try to build sets with these glyphs in them over the upcoming week. We will include them in the open v4.000 PR for users to download and try.

pkolchanov commented 6 years ago

Great!

chrissimpkins commented 6 years ago

Merged into cyrillic-updates branch. Here are Hack version 4.000;[400b70137]-dev builds that include these new glyphs and the updated designs to the Cyrillic te in #435 :

hack-400b70137-dev.tar.gz

Mind confirming that:

  1. The ruble is present in the sets and design appears as expected in the renders of these builds
  2. The ruble is present in the web font subsets (this is defined in our subsetting metadata and should be the case, but I have not confirmed yet). We include currency glyphs in our web font subsets and these new glyphs will be appropriate there
  3. The te updates are present in the sets and design appears as expected in the renders of these builds

Let me know if you think we are good to go here and I will merge all of these changes to dev for release as part of v4.000. Goal is to have this out sometime later this month (June).

pkolchanov commented 6 years ago

1)➕ Ruble is present in the ttf sets and renders how it should. 2)➖ Ruble is not present in the web font subsets for some reason 3)➕ Te changes are present and render as expected.

chrissimpkins commented 6 years ago

Hmmm... let me change how I am coding the ruble glyph and try to rebuild. Thanks for checking.

chrissimpkins commented 6 years ago

My error on coding the definitions for the subsetter. The compiler wanted the glyph name instead of Unicode code point. This is fixed in the releases attached to this post (Version 4.000;[d040a5837]-dev):

hack-d040a5837-dev.tar.gz

pkolchanov commented 6 years ago

Everything seems fine at d040a58.

chrissimpkins commented 6 years ago

Excellent! Let's merge these changes to dev branch. They will be included in the v4.000 release. Thank you very much for all of this work Pavel. It is greatly appreciated. There are other open Cyrillic glyph issue reports if you ever have time/interest for additional work in this set!