search

source-foundry / Hack

A typeface designed for source code
http://sourcefoundry.org/hack/
Other
16.39k stars 613 forks source link

[U+003C, U+003E] Made less-than `<` and greater-than `>` wider #434

Closed jdw1996 closed 6 years ago

jdw1996 commented 6 years ago

I made the less-than and greater-than symbols wider (i.e. taller) in all weights and styles to improve legibility, especially when they are used in XML-style tags.

jdw1996 commented 6 years ago

This PR addresses issue #417.

chrissimpkins commented 6 years ago

These changes are built as v4.000; [e2d8e94e7]-dev

Available in this archive for testing:

ttf.tar.gz

chrissimpkins commented 6 years ago

Windows users can use this development build installer:

https://github.com/source-foundry/Hack-Test-Win-Installer/releases/tag/v1.2.103

chrissimpkins commented 6 years ago

Looking great so far Joseph. The only thing that I have come across is a possible vertical alignment issue with the -> idiom. It looks like it may be the dash that may need to be shifted up slightly because we seem to be good with vertical position for idioms like >=, <=. I noticed this in C/C++ source while reviewing the changes in #433.

A collection of common source types is available in https://github.com/source-foundry/code-corpora if you'd like to have a look. Will have a more detailed look through other languages as we work on the changes in #433. These design changes are built into the fonts that are linked in that thread.

jdw1996 commented 6 years ago

You're right, it does appear that the hyphen is a little lower than the centre of the equals sign. At the font size I use for coding, I hadn't noticed that before.

chrissimpkins commented 6 years ago

Will need to look at that glyph in the context of these changes before we merge. Will probably warrant some changes there

chrissimpkins commented 6 years ago

I think that we should be set here after the hyphen vertical position change in f34aae6007d317b500acd1e6020c3b5dc3bc49fa. I centered the glyph to the horizontal stroke on the plus and to the space in the equal symbol. You can see an example of the orientation vs. your new gt glyph and the equal symbol in line 79 below:

uv3ey-image

Here is a new build if you'd like to take a look. Let me know if you are happy with this.

hack-f34aae600-dev.tar.gz

jdw1996 commented 6 years ago

Looks good to me, I'm happy with it. Thanks again for all the work you do!

chrissimpkins commented 6 years ago

These changes look great. Thanks for all of the design work here. They make a big difference. I am going to take a look in HTML where these will be very apparent and then will inspect both on Windows over the weekend. To confirm, you are viewing on Linux?

jdw1996 commented 6 years ago

Yes, I am viewing on Linux, and they look right to me.

chrissimpkins commented 6 years ago

OK. Just confirming instruction sets are ok. I won't be seeing that on macOS. Thanks!

chrissimpkins commented 6 years ago

Design changes in this proposal (same changes for the greater than glyph):

Current: o3hmj-image

New: yl0u9-image

chrissimpkins commented 6 years ago

Lots of cool short idioms in Haskell to explore these changes (as you pointed out in your IR) :)

chrissimpkins commented 6 years ago

Completed review of these shapes. They look great Joseph. Merging to dev branch and we will plan to include these changes in the v4.000 release of Hack. Thanks so much for all of your work on these designs. It is greatly appreciated!