search

source-foundry / Hack

A typeface designed for source code
http://sourcefoundry.org/hack/
Other
16.39k stars 613 forks source link

linux installation instructions outdated ? #442

Open jorgheymans opened 6 years ago

jorgheymans commented 6 years ago

the instructions mention to

but there is no config/fontconfig in the provided archive. I'm on Ubuntu, should i look for another way to install the font ?

chrissimpkins commented 6 years ago

It is located in the repository on the path https://github.com/source-foundry/Hack/blob/master/config/fontconfig/45-Hack.conf

Perhaps we could add this as an option to the linux installer script? The archives are prepared for cross-platform use.

chrissimpkins commented 6 years ago

Though I suppose it wouldn't be a tremendous issue to add a directory with the file to the compressed release archives or push this as a separate file in our releases. Thoughts?

jorgheymans commented 6 years ago

i think the easiest would be to adjust the wording of the documentation and point to the full URI of the fontconfig file in the git repo, no ambiguity. Still, it's funny to grab a config file from master together with a tagged release. It implies that the config file is valid for all versions, not saying that's an issue just pointing it out :)

chrissimpkins commented 6 years ago

That file was a PR in to the project and my understanding is that it is valid for all versions, past and future. Will update docs. Thanks for pointing it out Jorg. Appreciate it.

jorgheymans commented 6 years ago

Thanks Chris. Just noticed there is https://github.com/source-foundry/hack-linux-installer as well so i used that, it worked fine. It would make sense to mention it on the main installation page I think https://github.com/source-foundry/Hack#quick-installation , just like the windows installer is mentioned there. The 'manual' installation instructions would just be a fallback then for those that don't want to use the script.

chrissimpkins commented 6 years ago

Thank you!