search

source-foundry / Hack

A typeface designed for source code
http://sourcefoundry.org/hack/
Other
16.39k stars 613 forks source link

Bold brackets and braces in `dev` are too low #443

Closed jdw1996 closed 6 years ago

jdw1996 commented 6 years ago

It seems the centre-line of the square brackets and curly braces is lower in the bold weight than in the regular weight, in the version of the fonts currently in dev. Here's a GIF showing the difference, made using a fresh build of the fonts from dev:

hack-braces

I see the same thing when toggling between regular italics and bold italics. I'm not sure if it's a design decision or if the bold glyphs just weren't moved upward at the same time as the regular ones.

chrissimpkins commented 6 years ago

Thanks Joseph. Linux? Assuming that you see this across our target sizes 8-14?

Will take a look. I thought that I addressed all of these when we worked on the parentheses.

jdw1996 commented 6 years ago

Hi Chris. Yes, this is on Xubuntu Linux. I first noticed it in code in Vim, at size 11. I can post screenshots at a smaller size tomorrow if it will help.

chrissimpkins commented 6 years ago

Thanks. No need to post images. Just confirming. I will take a look at the design and post here when I have more information.

chrissimpkins commented 6 years ago

You are correct! There are vertical alignment issues in both bold and bold italic sets.

Regular

hack-regular

Italic

hack-italic

Bold

hack-bold

Bold Italic

hack-bolditalic

Thanks for checking this Joseph. Will make the changes so that they are aligned...

chrissimpkins commented 6 years ago

This should be fixed as of https://github.com/source-foundry/Hack/pull/444/commits/c1f45d1898bde61f7bb09d0b377cc6d996210d5a in PR https://github.com/source-foundry/Hack/pull/444

Want to build and confirm that you are seeing a fix on your platform?

jdw1996 commented 6 years ago

Hey Chris, I just rebuilt with the glyphs from the PR and it solved the issue. Thanks!

chrissimpkins commented 6 years ago

Excellent! Thanks for reporting this. I will merge it into dev. Have been a bit tied up with other things but am anxious to get this release out soon. Thanks again for all of the work that you contributed for 4.000. Things are looking good!

chrissimpkins commented 6 years ago

merged to dev for release as part of v4.000 release work