search

source-foundry / Hack

A typeface designed for source code
http://sourcefoundry.org/hack/
Other
16.33k stars 608 forks source link

Vertical alignment of curly braces (font size 16px) #538

Open mpstv opened 3 years ago

mpstv commented 3 years ago

Hello everyone. I found a problem with the alignment of curly braces. I didn’t find the same problem in the repository, read the file CONTRIBUTING.md and report the problem according to the points described there.

  • Font version:

3.003

  • Where you obtained the fonts

download from this repository

  • variant(s) of the Hack fonts that are affected

Regular

  • font size at which the problem was observed and whether it occurs at other sizes within the Core design target range

I font problem on font size 16px but did not reproduce it in Core design target range

  • operating system and version

windows 10 version 2004

  • application where the issue was observed and version (important for us to understand the renderer involved)

vscode version 1.52.1

  • screenshot images that visually demonstrate the problem
Regular
(reproduced)		 Bold
(not reproduced)		 Italic
(not reproduced)		 Bold Italic
(not reproduced)
изображение изображение изображение изображение
  • Please describe what led to the problem in detail.

This problem can be reproduce on windows 10 with 125% interface scaling.

I understand that these are not Core design target range and at the same time a rather narrow case, but the fact that this is reproduced only on the regular version of the font makes one think that it is possible to fix this not so difficult, so I decided to write about this problem anyway.

P.S. Thanks for the work you did to create this great font!

mpstv commented 3 years ago

I downloaded another version of Hack from https://github.com/source-foundry/Hack/pull/427 and this issue has not been reproduced anymore. I think this problem can be closed after the next release.