search

source-separation / tutorial

Tutorial covering Open Source tools for Source Separation.
https://source-separation.github.io/tutorial
Other
355 stars 39 forks source link

Pytorch Leaf Variable Handling Update #18

Closed boazcogan closed 3 years ago

boazcogan commented 3 years ago
Screen Shot 2021-04-14 at 8 36 05 PM

Pytorch seems to have updated how they handle leaf variables causing all of the tutorial sections in the gradient descent section to crash.

ethman commented 3 years ago

@pseeth Are you aware of a fix for this?

boazcogan commented 3 years ago

I haven't had the time to fully fix and formalize a commit for this yet, but most (if not all) of these issues can be fixed by embedding the code block in: with torch.zero_grad(): ... Here is a reference to a similar question and an answer from a pytorch developer.

erumbold commented 3 years ago

This still looks broken

justinsalamon commented 3 years ago

@pseeth

ethman commented 3 years ago

Whoops! I merged the fix for this (#26). I forgot to close the issue! My bad!